[PATCH] D39245: [ADT] Shuffle containers before sorting to uncover non-deterministic behavior

[Mandeep Singh Grang via Phabricator via llvm-commits]

mgrang added a subscriber: vsk.
mgrang added a comment.

In reply to @vsk "Do you mind sharing the llvm-cov test failure output?"

  tools/llvm-cov/hideUnexecutedSubviews.test:
  
  Regular build:
  Unexecuted instantiation: _Z4funcIiEiT_
    ------------------
  Unexecuted instantiation: _Z4funcIbEiT_
  
  Shuffle & sort:
  Unexecuted instantiation: _Z4funcIbEiT_
    ------------------
  Unexecuted instantiation: _Z4funcIiEiT_



  tools/llvm-cov/showTemplateInstantiations.cpp:
  
  Regular build:
    | _Z4funcIbEiT_:
    |    7|      1|int func(T x) {      // ALL-NEXT:    [[@LINE]]| 2|int func(T x) {
    |    8|      1|  if(x)              // ALL-NEXT:    [[@LINE]]| 2|  if(x)
    |    9|      1|    return 0;        // ALL-NEXT:    [[@LINE]]| 1|    return 0;
    |   10|      1|  else               // ALL-NEXT:    [[@LINE]]| 2|  else
    |   11|      0|    return 1;        // ALL-NEXT:    [[@LINE]]| 1|    return 1;
    |   12|      0|  int j = 1;         // ALL-NEXT:    [[@LINE]]| 0|  int j = 1;
    |   13|      1|}                    // ALL-NEXT:    [[@LINE]]| 2|}
    ------------------
    | _Z4funcIiEiT_:
    |    7|      1|int func(T x) {      // ALL-NEXT:    [[@LINE]]| 2|int func(T x) {
    |    8|      1|  if(x)              // ALL-NEXT:    [[@LINE]]| 2|  if(x)
    |    9|      0|    return 0;        // ALL-NEXT:    [[@LINE]]| 1|    return 0;
    |   10|      1|  else               // ALL-NEXT:    [[@LINE]]| 2|  else
    |   11|      1|    return 1;        // ALL-NEXT:    [[@LINE]]| 1|    return 1;
    |   12|      0|  int j = 1;         // ALL-NEXT:    [[@LINE]]| 0|  int j = 1;
    |   13|      1|}                    // ALL-NEXT:    [[@LINE]]| 2|}
  
  Shuffle & Sort:
    | _Z4funcIiEiT_:
    |    7|      1|int func(T x) {      // ALL-NEXT:    [[@LINE]]| 2|int func(T x) {
    |    8|      1|  if(x)              // ALL-NEXT:    [[@LINE]]| 2|  if(x)
    |    9|      0|    return 0;        // ALL-NEXT:    [[@LINE]]| 1|    return 0;
    |   10|      1|  else               // ALL-NEXT:    [[@LINE]]| 2|  else
    |   11|      1|    return 1;        // ALL-NEXT:    [[@LINE]]| 1|    return 1;
    |   12|      0|  int j = 1;         // ALL-NEXT:    [[@LINE]]| 0|  int j = 1;
    |   13|      1|}                    // ALL-NEXT:    [[@LINE]]| 2|}
    ------------------
    | _Z4funcIbEiT_:
    |    7|      1|int func(T x) {      // ALL-NEXT:    [[@LINE]]| 2|int func(T x) {
    |    8|      1|  if(x)              // ALL-NEXT:    [[@LINE]]| 2|  if(x)
    |    9|      1|    return 0;        // ALL-NEXT:    [[@LINE]]| 1|    return 0;
    |   10|      1|  else               // ALL-NEXT:    [[@LINE]]| 2|  else
    |   11|      0|    return 1;        // ALL-NEXT:    [[@LINE]]| 1|    return 1;
    |   12|      0|  int j = 1;         // ALL-NEXT:    [[@LINE]]| 0|  int j = 1;
    |   13|      1|}                    // ALL-NEXT:    [[@LINE]]| 2|}


Repository:
  rL LLVM

https://reviews.llvm.org/D39245