[PATCH] D39111: Extensible LLVM RTTI

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 24 09:04:33 PDT 2017


dblaikie added inline comments.


================
Comment at: Support/ExtensibleRTTITest.cpp:21
+public:
+  static char ID;
+};
----------------
These chars could be provided in the CRTP base, perhaps? Less boilerplate. (though this would mean they'd have linkonce linkage, rather than having strong external definitions - but I doubt that duplication in objects would be too painful?)

Could even be local to the RTTIExtends::classID function (& dynamicClassID would just call classID)


Repository:
  rL LLVM

https://reviews.llvm.org/D39111





More information about the llvm-commits mailing list