[PATCH] D36104: [AArch64] Coalesce Copy Zero during instruction selection

Geoff Berry via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 24 08:20:12 PDT 2017


gberry added a comment.

This looks pretty good to me (with one minor comment), but someone else should probably approve it.



================
Comment at: lib/Target/AArch64/AArch64ISelDAGToDAG.cpp:2809
+    SDValue New;
+    if (Node->getValueType(Node->getNumValues() - 1) == MVT::Glue)
+      New =
----------------
I think you can get rid of this if/else by re-writing as:

```
SDValue New = CurDAG->getNode(ISD::CopyToReg, SDLoc(Node), Node->getVTList(), makeArrayRef(Ops, NumOperands));
```


Repository:
  rL LLVM

https://reviews.llvm.org/D36104





More information about the llvm-commits mailing list