[PATCH] D38626: Invalid used of 'w' suffix on push and pop using 64-bit register

[Simon Pilgrim via Phabricator via llvm-commits]

RKSimon added inline comments.


================
Comment at: lib/Target/X86/Disassembler/X86DisassemblerDecoder.cpp:968
+      attrMask &= ~ATTR_ADSIZE;
+      attrMask |= ATTR_XS;
+    }
----------------
avt77 wrote:
> craig.topper wrote:
> > Why are you forcing the XS attribute?
> I thought we should transform ADSIZE in XS here. It seems I was wrong: everything works w/o such a transformation. I'll update the patch asap.
Can't this be done as just:
```
attrMask |= ATTR_REXW;
attrMask &= ~ATTR_ADSIZE;
```


https://reviews.llvm.org/D38626