[PATCH] D39117: [mips] Match 'ins' and its' variants with C++ code

Simon Dardis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 24 04:06:40 PDT 2017


sdardis updated this revision to Diff 120036.
sdardis marked 3 inline comments as done.
sdardis added a comment.

Address review comments.

I've reflowed the logic for handling dins* to match the ISA documentation, with the exception of an early return if the size is zero.


https://reviews.llvm.org/D39117

Files:
  lib/Target/Mips/MicroMips64r6InstrInfo.td
  lib/Target/Mips/MicroMipsInstrInfo.td
  lib/Target/Mips/Mips64InstrInfo.td
  lib/Target/Mips/MipsInstrInfo.td
  lib/Target/Mips/MipsSEISelDAGToDAG.cpp
  test/CodeGen/Mips/dins.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D39117.120036.patch
Type: text/x-patch
Size: 8269 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171024/7ef21adb/attachment-0001.bin>


More information about the llvm-commits mailing list