[PATCH] D38846: [ELF] - Linkerscript: fix issue with SUBALIGN.

[James Henderson via Phabricator via llvm-commits]

jhenderson added a comment.

In https://reviews.llvm.org/D38846#904885, @grimar wrote:

> - Added testcases for testing ALIGN expression.


Thanks, they look fine from my point of view, aside from one minor point.



================
Comment at: test/ELF/linkerscript/align.s:84
 
+## Test we fail gracefuly when alignment value is not a power of 2 (#1).
+# RUN: echo "SECTIONS { . = 0x123; . = ALIGN(3); .aaa : { *(.aaa) } }" > %t.script
----------------
Minor point: to mirror the zero value cases above, could you switch round the order of these two cases, please.


https://reviews.llvm.org/D38846