[PATCH] D39194: [ARM] Include operand class name in dev diags

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 23 16:00:34 PDT 2017


rengolin added a comment.

Right, looking back, this is the only other use of `DevDiags`. At all.

I completely missed that when reviewing https://reviews.llvm.org/D31530, and I see now that this is the wrong implementation. We should not have the flag at all, and that should be just a simple usage of `DEBUG()`.

We already have the stderr/stdout sync issue everywhere, and that's not a strong enough reason to add a flag for a single printf (or we wouldn't have `DEBUG` in the first place).

cheers,
--renato


Repository:
  rL LLVM

https://reviews.llvm.org/D39194





More information about the llvm-commits mailing list