[PATCH] D39194: [ARM] Include operand class name in dev diags

[Oliver Stannard via Phabricator via llvm-commits]

olista01 added a comment.

Why do you think this should be kept downstream? It's a debug option which I've found useful while adding diagnostics for assembly options, none of which I plan on keeping downstream.



================
Comment at: lib/Target/ARM/AsmParser/ARMAsmParser.cpp:10216
+          OS << " class "
+#ifndef NDEBUG
+             << getMatchClassName((MatchClassKind)I.getOperandClass())
----------------
rengolin wrote:
> that's a bit hackish, why not always?
The getMatchClassName is only generated for builds with assertions. This code is only used when the -arm-arm-parser-dev-diags option is used, which is intended for LLVM developers only, so I think it makes sense to keep it this way.


Repository:
  rL LLVM

https://reviews.llvm.org/D39194