[PATCH] D38799: [mips] Add MIPS ABI enumeration and getter function to the Triple class

Simon Atanasyan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 23 14:13:12 PDT 2017


atanasyan added a comment.

Hi Renato,

In https://reviews.llvm.org/D38799#904200, @rengolin wrote:

> I really don't like treating Mips different than all others. But I really don't know enough about the Mips ABI problems to come up with a better way (all I know it's that they're worse than ARM's ABI problems).


This patch is really MIPS specific. But I think the problem is actually more general. Now, for example, we have three "environment" GNU, EABI, and Musl and "HF" ABI variants for each of this environment. If we support more C libraries, we will have to add new `Environment` items for each supported environment+ABI pair. Something like NewLib, NewLibHF etc. The idea of this patch is to separate notions of Environment and ABI and escape growing the `Environment` enumeration if we need to add new ABI for existing "environment".


Repository:
  rL LLVM

https://reviews.llvm.org/D38799





More information about the llvm-commits mailing list