[PATCH] D39139: LLD/ELF: Allow targets to set e_flags

[Konstantin Zhuravlyov via Phabricator via llvm-commits]

kzhuravl added inline comments.


================
Comment at: ELF/Arch/MipsArchTree.cpp:284
 
 template <class ELFT> uint32_t elf::calcMipsEFlags() {
   std::vector<FileFlags> V;
----------------
ruiu wrote:
> t-tye wrote:
> > Would it be better to just rename this calcEFlags to match how the other targets are now?
> Yes, please just rename it.
Could you elaborate on what needs renaming?

Reasons why I left it as is:
  - Mips class derived from TargetInfo is in anonymous namespace in Mips.cpp, so inaccessible in MipsArchTree.cpp
  - calcMipsEFlags is using few functions (e.g. checkFlags) that are static, so inaccessible in Mips.cpp

I was thinking of merging Mips.cpp and MipsArchTree.cpp into one file, but not sure if it is the right choice (I do not know why it was done this way in the first place).


https://reviews.llvm.org/D39139