[compiler-rt] r316348 - Revert "[Compiler-rt][MIPS] Fix cross build for XRAY."

Evgeniy Stepanov via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 23 10:13:24 PDT 2017


Author: eugenis
Date: Mon Oct 23 10:13:24 2017
New Revision: 316348

URL: http://llvm.org/viewvc/llvm-project?rev=316348&view=rev
Log:
Revert "[Compiler-rt][MIPS] Fix cross build for XRAY."

Breaks build:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux/builds/4677/steps/build%20with%20ninja/logs/stdio

In file included from compiler-rt/lib/xray/xray_fdr_logging.cc:34:
In file included from compiler-rt/lib/xray/xray_fdr_logging_impl.h:36:
In file included from compiler-rt/lib/xray/xray_flags.h:18:
compiler-rt/lib/xray/../sanitizer_common/sanitizer_flag_parser.h:23:7: error: '__sanitizer::FlagHandlerBase' has virtual functions but non-virtual destructor [-Werror,-Wnon-virtual-dtor]
class FlagHandlerBase {

Modified:
    compiler-rt/trunk/lib/xray/CMakeLists.txt

Modified: compiler-rt/trunk/lib/xray/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/xray/CMakeLists.txt?rev=316348&r1=316347&r2=316348&view=diff
==============================================================================
--- compiler-rt/trunk/lib/xray/CMakeLists.txt (original)
+++ compiler-rt/trunk/lib/xray/CMakeLists.txt Mon Oct 23 10:13:24 2017
@@ -60,12 +60,6 @@ include_directories(../../include)
 
 set(XRAY_CFLAGS ${SANITIZER_COMMON_CFLAGS})
 set(XRAY_COMMON_DEFINITIONS XRAY_HAS_EXCEPTIONS=1)
-
-if (NOT MSVC AND NOT DEFINED TARGET_FLAGS)
-  set(TARGET_FLAGS ${CMAKE_CXX_FLAGS})
-  separate_arguments(TARGET_FLAGS)
-endif()
-
 append_list_if(
   COMPILER_RT_HAS_XRAY_COMPILER_FLAG XRAY_SUPPORTED=1 XRAY_COMMON_DEFINITIONS)
 append_list_if(
@@ -73,7 +67,7 @@ append_list_if(
 
 add_compiler_rt_object_libraries(RTXray
   ARCHS ${XRAY_SUPPORTED_ARCH}
-  SOURCES ${XRAY_SOURCES} CFLAGS ${XRAY_CFLAGS} ${TARGET_FLAGS}
+  SOURCES ${XRAY_SOURCES} CFLAGS ${XRAY_CFLAGS}
   DEFS ${XRAY_COMMON_DEFINITIONS})
 
 add_compiler_rt_component(xray)
@@ -88,7 +82,7 @@ foreach(arch ${XRAY_SUPPORTED_ARCH})
      STATIC
      ARCHS ${arch}
      SOURCES ${${arch}_SOURCES}
-     CFLAGS ${XRAY_CFLAGS} ${TARGET_FLAGS}
+     CFLAGS ${XRAY_CFLAGS}
      DEFS ${XRAY_COMMON_DEFINITIONS}
      OBJECT_LIBS ${XRAY_COMMON_RUNTIME_OBJECT_LIBS}
      PARENT_TARGET xray)




More information about the llvm-commits mailing list