[PATCH] D39171: AMDGPU: Handle s_buffer_load_dword hazard on SI

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: lib/Target/AMDGPU/GCNHazardRecognizer.cpp:347
+
+  // This fixes what appears to be undocumented hardware behavior in SI where
+  // s_mov writing a descriptor and s_buffer_load_dword reading the descriptor
----------------
nhaehnle wrote:
> This could be merged with the previous loop, right?
Do you mean just SI? Needs a subtarget check? 


================
Comment at: lib/Target/AMDGPU/GCNHazardRecognizer.cpp:354
+  // probably never encountered in the closed-source land.
+  if (SMRD->getOpcode() == AMDGPU::S_BUFFER_LOAD_DWORD_IMM ||
+      SMRD->getOpcode() == AMDGPU::S_BUFFER_LOAD_DWORDX2_IMM ||
----------------
Probably should avoid switch with something like isSMRD() && has buffer operand


https://reviews.llvm.org/D39171