[PATCH] D38581: [IRCE] Fix intersection between signed and unsigned ranges

[Anna Thomas via Phabricator via llvm-commits]

anna accepted this revision.
anna added a comment.
This revision is now accepted and ready to land.

LGTM . Since context is not here but the actual logic was correct and unchanged wrt the previous review, I went by that.



================
Comment at: test/Transforms/IRCE/unsigned_comparisons_ult.ll:360
+
+; CHECK:      test_09
+
----------------
mkazantsev wrote:
> anna wrote:
> > Please add checks here as `CHECK-NOT` for pre and post loops.
> On line 11, we had a check that IRCE didn't apply to the test:
> `; CHECK-NOT: irce: in function test_09: constrained Loop at depth 1 containing: %loop<header><exiting>,%in.bounds<latch><exiting>`
> But OK, I will add these asserts as well. :)
ah yes, missed that. Thanks for making it clearer here!


https://reviews.llvm.org/D38581