[PATCH] D39151: [tsan] Fix warnings in tsan_interceptors.cc from expansion of variadic macros

Francis Ricci via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 23 08:16:34 PDT 2017


fjricci added inline comments.


================
Comment at: lib/sanitizer_common/sanitizer_common_defs.h:16
+
+#define STRINGIFY(A) STRINGIFY_(A)
+#define STRINGIFY_(A) #A
----------------
I think this should go in sanitizer_internal_defs.h


================
Comment at: lib/tsan/rtl/tsan_interceptors.h:59
+  if (!thr->is_inited || thr->ignore_interceptors || thr->in_ignored_lib) \
+    return REAL(func)(__VA_ARGS__);                                       \
+  /**/
----------------
Is it possible to solve this with `##__VA_ARGS__` instead? Not super familiar with how all of this stuff works though.


https://reviews.llvm.org/D39151





More information about the llvm-commits mailing list