[PATCH] D39148: [COFF] Add support for /WX

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: COFF/DriverUtils.cpp:743
+  if (auto *Arg = Args.getLastArg(OPT_WX, OPT_WX_no))
+    Config->FatalWarnings = Arg->getOption().getID() == OPT_WX;
+
----------------
nit: add parentheses on RHS.


================
Comment at: COFF/Options.td:87-88
 def force_unresolved : F<"force:unresolved">;
+def WX : F<"WX">, HelpText<"Treat warnings as errors">;
+def WX_no : F<"WX:no">, HelpText<"Don't treat warnings as errors">;
 
----------------
compnerd wrote:
> You should move this down and use the `QB` multiclass instead.
Yes, you can use `QB` instead.


https://reviews.llvm.org/D39148