[PATCH] D39140: LLD/ELF/AMDGPU: Process AMDGPU-specific e_flags

Tony Tye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 20 19:54:26 PDT 2017


t-tye added inline comments.


================
Comment at: ELF/Arch/AMDGPU.cpp:47
+    cast<ObjFile<ELF64LE>>(ObjectFiles.front())->getObj().getHeader()->e_flags;
+  for (const auto &F : ObjectFiles) {
+    uint32_t CurrentEFlags =
----------------
Is it worth avoiding checking the first element since it has already been inspected. For example:


```
for (const auto &F : ArrayRef(ObjectFiles).slice(1)) {
```


https://reviews.llvm.org/D39140





More information about the llvm-commits mailing list