[PATCH] D39107: [WebAssembly] MC: Don't allow zero sized data segments

Derek Schuff via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 20 17:27:32 PDT 2017


dschuff added inline comments.


================
Comment at: lib/MC/WasmObjectWriter.cpp:526
     } else if (auto *Fill = dyn_cast<MCFillFragment>(&Frag)) {
       DataBytes.insert(DataBytes.end(), Fill->getSize(), Fill->getValue());
     } else {
----------------
should we set LastFragmentSize to the fill size here and/or for align frags above? I guess if the answer is "no" it's because they do not represent symbols?


https://reviews.llvm.org/D39107





More information about the llvm-commits mailing list