[PATCH] D39103: [RISCV 12.5/n] Codegen support for memory operations on global addresses

[Philip Reames via Phabricator via llvm-commits]

reames accepted this revision.
reames added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Target/RISCV/RISCVMCInstLower.cpp:27
 
-void llvm::LowerRISCVMachineInstrToMCInst(const MachineInstr *MI,
-                                          MCInst &OutMI) {
----------------
FYI, the diff here is confusing and part of what made me request you split this.  If you'd extracted the helper function as a separate NFC change without review (which would have been fine), the reduced diff would have been a lot more obvious.


https://reviews.llvm.org/D39103