[PATCH] D39067: [LLD] [COFF] Move MinGW specific functions/classes to a separate file. NFC.

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 19 13:33:48 PDT 2017


mstorsjo added a comment.

FWIW, the StringSet forward declaration turned out to fail on clang while it worked fine when built with GCC, see e.g. http://lab.llvm.org:8011/builders/lld-x86_64-freebsd/builds/11694/steps/build_Lld/logs/stdio (https://godbolt.org/g/czUQZ8 for a simplified example of the issue). I did a quick fix by removing the forward declaration again and using the fully qualified llvm::StringSet in MinGW.h (instead of the using statement that you weren't so fond of earlier in review).


Repository:
  rL LLVM

https://reviews.llvm.org/D39067





More information about the llvm-commits mailing list