[PATCH] D39067: [LLD] [COFF] Move MinGW specific functions/classes to a separate file. NFC.

Martin Storsjö via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 18 23:48:46 PDT 2017


mstorsjo marked an inline comment as done.
mstorsjo added inline comments.


================
Comment at: COFF/MinGW.h:21
+
+using llvm::StringSet;
+
----------------
ruiu wrote:
> Instead of doing this, please include LLVM.h just like other headers in lld do.
LLVM.h doesn't include or forward-declare StringSet, but if I add it there, I can get this working (as long as any caller trying to instantiate the `AutoExporter` class has pulled in the proper definition of StringSet).


https://reviews.llvm.org/D39067





More information about the llvm-commits mailing list