[llvm] r316144 - Simplify.

Rafael Espindola via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 18 18:32:18 PDT 2017


Author: rafael
Date: Wed Oct 18 18:32:18 2017
New Revision: 316144

URL: http://llvm.org/viewvc/llvm-project?rev=316144&view=rev
Log:
Simplify.

Modified:
    llvm/trunk/lib/BinaryFormat/Magic.cpp

Modified: llvm/trunk/lib/BinaryFormat/Magic.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/BinaryFormat/Magic.cpp?rev=316144&r1=316143&r2=316144&view=diff
==============================================================================
--- llvm/trunk/lib/BinaryFormat/Magic.cpp (original)
+++ llvm/trunk/lib/BinaryFormat/Magic.cpp Wed Oct 18 18:32:18 2017
@@ -185,8 +185,8 @@ file_magic llvm::identify_magic(StringRe
     if (startswith(Magic, "MZ") && Magic.size() >= 0x3c + 4) {
       uint32_t off = read32le(Magic.data() + 0x3c);
       // PE/COFF file, either EXE or DLL.
-      if (off + sizeof(COFF::PEMagic) <= Magic.size() &&
-          memcmp(Magic.data() + off, COFF::PEMagic, sizeof(COFF::PEMagic)) == 0)
+      if (Magic.substr(off).startswith(
+              StringRef(COFF::PEMagic, sizeof(COFF::PEMagic))))
         return file_magic::pecoff_executable;
     }
     break;




More information about the llvm-commits mailing list