[PATCH] D38937: [LLD] [COFF] Exclude certain static libraries and object files when exporting all symbols

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 18 12:07:41 PDT 2017


ruiu added a comment.

I don't see a reason to use OO over plain functions in this patch, but this is probably okay. We can revisit it later. But I feel we are having too many functions for MinGW in Driver.cpp, so I was thinking that it might be a good idea to great MinGW.{h,cpp} in the COFF directory to put MinGW-related stuff there. What do you think?


https://reviews.llvm.org/D38937





More information about the llvm-commits mailing list