[PATCH] D38846: [ELF] - Linkerscript: fix issue with SUBALIGN.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: ELF/ScriptParser.cpp:645
 
+static Expr checkAlignment(Expr E, std::string &Loc) {
+  return [=] {
----------------
I'd make this a member of ScriptParser to eliminate `Loc`.


================
Comment at: ELF/ScriptParser.cpp:649
+    if (!isPowerOf2_64(Alignment))
+      error(Loc + ": alignment must be power of 2");
+    return Alignment;
----------------
You should return 1 instead of some erroneous value.


https://reviews.llvm.org/D38846