[lld] r316077 - [ELF] - Moved, fixed outdated comment. NFC.

George Rimar via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 18 06:06:18 PDT 2017


Author: grimar
Date: Wed Oct 18 06:06:18 2017
New Revision: 316077

URL: http://llvm.org/viewvc/llvm-project?rev=316077&view=rev
Log:
[ELF] - Moved, fixed outdated comment. NFC.

It was at wrong place.

Modified:
    lld/trunk/ELF/SyntheticSections.cpp

Modified: lld/trunk/ELF/SyntheticSections.cpp
URL: http://llvm.org/viewvc/llvm-project/lld/trunk/ELF/SyntheticSections.cpp?rev=316077&r1=316076&r2=316077&view=diff
==============================================================================
--- lld/trunk/ELF/SyntheticSections.cpp (original)
+++ lld/trunk/ELF/SyntheticSections.cpp Wed Oct 18 06:06:18 2017
@@ -1316,10 +1316,6 @@ static bool sortMipsSymbols(const Symbol
   return L.Symbol->GotIndex < R.Symbol->GotIndex;
 }
 
-// Finalize a symbol table. The ELF spec requires that all local
-// symbols precede global symbols, so we sort symbol entries in this
-// function. (For .dynsym, we don't do that because symbols for
-// dynamic linking are inherently all globals.)
 void SymbolTableBaseSection::finalizeContents() {
   getParent()->Link = StrTabSec.getParent()->SectionIndex;
 
@@ -1344,6 +1340,9 @@ void SymbolTableBaseSection::finalizeCon
   }
 }
 
+// The ELF spec requires that all local symbols precede global symbols, so we
+// sort symbol entries in this function. (For .dynsym, we don't do that because
+// symbols for dynamic linking are inherently all globals.)
 void SymbolTableBaseSection::postThunkContents() {
   if (this->Type == SHT_DYNSYM)
     return;




More information about the llvm-commits mailing list