[PATCH] D38977: COFF: Add type server pdb files to linkrepro tar file.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added a comment.

In https://reviews.llvm.org/D38977#900155, @ruiu wrote:

> If not GNU but all tar commands support the 'O' option, then yes, that should suffice.


Seems worth a try. Looks like gnuwin32 and Darwin tar also support it, and so does FreeBSD: https://github.com/freebsd/freebsd/blob/master/contrib/libarchive/tar/bsdtar.c#L528



================
Comment at: lld/test/COFF/linkrepro-pdb.test:4-5
+RUN: rm -rf %t && mkdir -p %t && cd %t
+RUN: yaml2obj %S/Inputs/pdb-type-server-simple-a.yaml -o a.obj
+RUN: yaml2obj %S/Inputs/pdb-type-server-simple-b.yaml -o b.obj
+RUN: llvm-pdbutil yaml2pdb %S/Inputs/pdb-type-server-simple-ts.yaml -pdb ts.pdb
----------------
zturner wrote:
> Should these output files be going somewhere prefixed with `%t`?
We do `cd %t` above, so they'll end up in that directory.


https://reviews.llvm.org/D38977