[PATCH] D38977: COFF: Add type server pdb files to linkrepro tar file.

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

In https://reviews.llvm.org/D38977#900152, @zturner wrote:

> In https://reviews.llvm.org/D38977#900140, @ruiu wrote:
>
> > Yeah, some tests failed on some bots due to the maximum path limitation on Windows. /linkrepro actually works just fine, but in order to verify its contents, we have to untar the produced file into a working directory. That sometimes fails because the length of the current working directory + pathnames in the tar could easily exceed 255 characters long on some bots.
>
>
> Would it be sufficient to:
>
> a) Use `tar tf` to list the contents
>  b) untar the file you're interested in like this:
>
>   RUN: tar xOf repro.tar %t/ts.pdb > %t/repro/ts.pdb
>   RUN: diff %t/ts.pdb %t/repro/ts.pdb
>


In case it wasn't clear, the idea behind `tar tf` was to run a FileCheck to verify the contents of the tar file.


https://reviews.llvm.org/D38977