[PATCH] D38626: Invalid used of 'w' suffix on push and pop using 64-bit register

Andrew V. Tischenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Oct 17 05:20:18 PDT 2017


avt77 added inline comments.


================
Comment at: lib/Target/X86/Disassembler/X86DisassemblerDecoder.cpp:968
+      attrMask &= ~ATTR_ADSIZE;
+      attrMask |= ATTR_XS;
+    }
----------------
craig.topper wrote:
> Why are you forcing the XS attribute?
I thought we should transform ADSIZE in XS here. It seems I was wrong: everything works w/o such a transformation. I'll update the patch asap.


https://reviews.llvm.org/D38626





More information about the llvm-commits mailing list