[PATCH] D35625: Removal of microMIPS64R6

[Aleksandar Beserminji via Phabricator via llvm-commits]

abeserminji added inline comments.


================
Comment at: lib/Target/Mips/MipsTargetMachine.cpp:188-192
+  if (CPU == "mips64r6" && HasMicroMipsAttr) {
+    errs() << "LLVM currently does not support microMIPS for '" << CPU << "'.\n";
+    HasMicroMipsAttr = false;
+    HasNoMicroMipsAttr = true;
+  }
----------------
sdardis wrote:
> Take the context from the current Function and use emitError giving the function name + error message.
> 
> See include/llvm/IR/LLVMContext.h:300~ for emitError.
I removed this check here, because I was not able to reproduce the error at this place. The check in //MipsSubtarget.cpp// at //107// always performs first, so this seemed to me like unnecessary thing. Although, correct me if I'm wrong, I might missed some case where this is called before the mentioned check in //MipsSubtarget.cpp//.


Repository:
  rL LLVM

https://reviews.llvm.org/D35625