[PATCH] D38977: COFF: Add type server pdb files to linkrepro tar file.

[Zachary Turner via Phabricator via llvm-commits]

zturner added a comment.

It's possible I'm missing something here, but I don't see anything specific to linkrepro or TAR files in any of this patch.  This leads me to believe /LINKREPRO is doing a full PDB link, including merging types and symbols from all object files.  resolving type servers and merging those in as well.

If I understand this feature correctly, /LINKREPRO isn't actually supposed to //link// anything.  It just copies the necessary files to a TAR file and creates a response file so that that response file, combined with the TAR file can then be linked on a //different// machine.

If my understanding is wrong feel free to correct me, but if it's right, then this seems overly heavyweight.  It looks like this is doing a full PDB link but injecting some sort of Writer class that instead of writing to an output executable + PDB file, writes to a TAR file.

When we discussed this on IRC, I thought the solution was just going to find the type server PDB and add it to the tar file, but not actually link or do anything expensive.


https://reviews.llvm.org/D38977