[PATCH] D38846: [ELF] - Linkerscript: Fix issues with SUBALIGN.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 16 10:20:55 PDT 2017


ruiu added a comment.

You are right that we should handle 0 as 1. But please remove code for the rigorous error checking for const-ness. We just want to provide a reasonable error reporting, and this patch seem to have gone a bit too far. There are a lot of ways you can do wrong things using linker scripts, and I don't want to focus too much on some arbitrary corner case.


https://reviews.llvm.org/D38846





More information about the llvm-commits mailing list