[PATCH] D38960: [Local] Fix a bug in the domtree update logic for MergeBasicBlockIntoOnlyPred.

Balaram Makam via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Oct 16 10:05:53 PDT 2017


bmakam added a comment.

In https://reviews.llvm.org/D38960#898713, @kuhar wrote:

> I think that this deserves a comment with a (partial) example, otherwise the change looks suspicious.


Fair point. All the users of MergeBasicBlockIntoOnlyPred in the tree, do not pass DT to the function, so it is never exposed. Is there a way to test this in tree by passing DT to MergeBasicBlockIntoOnlyPred?


https://reviews.llvm.org/D38960





More information about the llvm-commits mailing list