[PATCH] D38846: [ELF] - Linkerscript: Fix issues with SUBALIGN.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 15 13:54:33 PDT 2017


ruiu added a comment.

I'd think you are overthinking. I don't think it is a good idea to add that many parameters to various functions just to check for a misuse of some rarely used feature. We should report an error instead of firing an assertion for SUBALIGN expression 0, but for const-ness, I'm not too excited about rigorous error checking.


https://reviews.llvm.org/D38846





More information about the llvm-commits mailing list