[PATCH] D38676: [LV] Model masking in VPlan, introducing VPInstructions

Renato Golin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Oct 15 08:36:49 PDT 2017


rengolin added a comment.

In https://reviews.llvm.org/D38676#898099, @aemerson wrote:

> A minor nit but LGTM. I don't have an aversion to "dead code" if it's going to be used in the near future, so perhaps to make the patch smaller split it into an initial patch to add VPlanValue.h and then the VPlanBuilder.h as well as the changes to the documentation. Those pieces seem uncontroversial to me, before moving onto the vectorizer. @mkuper does this make sense?


That was basically my point. :)


https://reviews.llvm.org/D38676





More information about the llvm-commits mailing list