[PATCH] D35014: [X86] PR32755 : Improvement in CodeGen instruction selection for LEAs.

Jatin Bhateja via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Oct 14 01:06:54 PDT 2017


jbhateja updated this revision to Diff 119010.
jbhateja added a comment.

- https://reviews.llvm.org/D35014 : Review comments resolution
- Removing 2 tests, pulled their latest renamed versions from trunk.
- [X86] : Factorize LEA, handling for patterns involing SUBREG_TO_REG as LEA operands.
- Few more changes for LEA factorization.
- Updating test lea-opt-cse3.ll
- Formatting changes.
- Formatting changes
- Changes to avoid creating costly LEAs in loops, strength reduction for simple LEAs with unit scale
- Updating test.
- [X86] Limiting the scope of DAG operands folding while AM based instruction selection to LEAs.
- Merge from trunk.
- Extending aggressive AM based folding for LEAs to cover more cases.
- Updating test post rebase.
- Formatting changes + fine tuning pattern matching condition.
- Adding a check for subtarget feature Slow3OpLEA in pattern matching.
- Few synthetic changes.
- Undefining result operand of factored statement to preserve SSA nature of Machine IR.
- Merge branch 'master' of https://github.com/llvm-mirror/llvm
- Merge branch 'master' of https://github.com/llvm-mirror/llvm
- Updating tests for reported PRs for initial patch.
- Merge branch 'master' of https://github.com/llvm-mirror/llvm
- Pull from trunk.
- Operands of LEAs must be of same register class.
- Revert "Operands of LEAs must be of same register class."


https://reviews.llvm.org/D35014

Files:
  include/llvm/CodeGen/MachineInstr.h
  include/llvm/CodeGen/SelectionDAG.h
  lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp
  lib/Target/X86/X86ISelDAGToDAG.cpp
  lib/Target/X86/X86OptimizeLEAs.cpp
  test/CodeGen/X86/GlobalISel/callingconv.ll
  test/CodeGen/X86/GlobalISel/gep.ll
  test/CodeGen/X86/GlobalISel/memop-scalar.ll
  test/CodeGen/X86/lea-opt-cse1.ll
  test/CodeGen/X86/lea-opt-cse2.ll
  test/CodeGen/X86/lea-opt-cse3.ll
  test/CodeGen/X86/lea-opt-cse4.ll
  test/CodeGen/X86/mul-constant-i16.ll
  test/CodeGen/X86/mul-constant-i32.ll
  test/CodeGen/X86/mul-constant-i64.ll
  test/CodeGen/X86/mul-constant-result.ll
  test/CodeGen/X86/pr34629.ll
  test/CodeGen/X86/pr34634.ll
  test/CodeGen/X86/umul-with-overflow.ll
  test/Transforms/LoopStrengthReduce/X86/ivchain-X86.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D35014.119010.patch
Type: text/x-patch
Size: 51904 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171014/544cbc35/attachment-0001.bin>


More information about the llvm-commits mailing list