[PATCH] D38902: AMDGPU: Add AMDGPU HSA Kernel Descriptor

Tony Tye via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 13 20:13:04 PDT 2017


t-tye accepted this revision.
t-tye added a comment.
This revision is now accepted and ready to land.

LGTM with minor layout suggestion.



================
Comment at: docs/AMDGPUUsage.rst:1489
+     454     1 bit   EnableSGPRPrivateSegment        *see above*
+                     Size
+     455     1 bit   EnableSGPRGridWorkgroup         Not implemented in CP and
----------------
Maybe Size will fit on the line above now? Same comment for following rows.


https://reviews.llvm.org/D38902





More information about the llvm-commits mailing list