[PATCH] D38911: [cfi] Test cross-dso CFI on Android.

[Peter Collingbourne via Phabricator via llvm-commits]

pcc added inline comments.


================
Comment at: compiler-rt/test/lit.common.cfg:214
+    lit_config.fatal("Failed to read ro.build.version.sdk (using '%s' as adb): got '%s'" % (adb, android_api_level_str))
+  for x in range(14, android_api_level + 1):
+      config.available_features.add('android-' + str(x));
----------------
eugenis wrote:
> This could be a bit excessive...
> It would add ~13 new features, and we currently only use one (android-26). AFAIK, lit does not allow numeric comparisons in UNSUPPORTED and REQUIRES headers.
I'd prefer to make this define only `android-26` if the version is >=26, as that should make life easier for someone who is trying to figure out where `android-26` is coming from. If we need more versions, we could perhaps figure something else out.


https://reviews.llvm.org/D38911