[PATCH] D38825: [SCEV] Teach SCEV to find maxBECount when loop endbound is variant

[Anna Thomas via Phabricator via llvm-commits]

anna added inline comments.


================
Comment at: llvm/trunk/lib/Analysis/ScalarEvolution.cpp:9692
 
+const SCEV *ScalarEvolution::computeMaxBECount(const SCEV *Start,
+                                               const SCEV *Stride,
----------------
sanjoy wrote:
> This logic is specific to {Start,+,Stride} SLT End, right?  If so, please name it in a way to make that obvious and mention that in the comment.
The logic is specific to  {Start,+,Stride} LT End, it can be s< or u<. 
 
I'll change it to `computeMaxBECountForLT` and add a comment about the type of addrec and termination condition that's supported.


Repository:
  rL LLVM

https://reviews.llvm.org/D38825