[PATCH] D38894: [RFC][Tablegen] Add CCIfSplitFrom and CCPassIndirectBySamePointer Calling Convention Interfaces

Shiva Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Oct 13 10:19:48 PDT 2017


shiva0217 added a comment.

In https://reviews.llvm.org/D38894#897090, @rnk wrote:

> This needs tests, and it would surely be simpler if the frontend didn't emit illegal types as arguments. We normally handle this kind of thing in clang, so you would get an LLVM `f128*` argument.


Hi @rnk, Thanks for the quick reply!
Yes, most of the cases we could handle by clang.
One of the cases couldn't is that the function created by llvm. E.g. softfloat functions which clang will see it as floating operations.
So we still need to write a custom function to deal with.

Could you guide me how to add the test case for the calling convention interfaces?
Should I patch some backend and write MC testcases for the backend or there is better way ?


Repository:
  rL LLVM

https://reviews.llvm.org/D38894





More information about the llvm-commits mailing list