[PATCH] D36706: DAGCombiner: Add form of isFPExtFree to check uses

Matt Arsenault via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 12 21:30:45 PDT 2017


arsenm added a comment.

In https://reviews.llvm.org/D36706#891897, @nemanjai wrote:

> It would appear to me that the PPC-only portion of this is NFC since it'll still return `true` for any floating point destination type. So I would say that the PPC back end is fine with those (as long as the assert gets a message :)).
>  However, shouldn't this patch have a test case?


https://reviews.llvm.org/D38510 includes the implementation that uses it


https://reviews.llvm.org/D36706





More information about the llvm-commits mailing list