[PATCH] D38668: [X86] Do not generate __multi3 for mul i128 on X86

[Riyaz V Puthiyapurayil via Phabricator via llvm-commits]

RVP added a comment.

The issue with `.Lfc` labels is due to https://reviews.llvm.org/rL315259. By pulling that change in, it is no longer generated by `update_llc_test_checks.py`

I found that the other lit tests that were probably failing for you. These are call currently invoking `__multi3`. With my change, they no longer call `__multi3`. I missed uploading those 5 tests and that is why they failed for you.

Before I upload those changes, can you answer these questions?

1. How were these tests verified before? On i386, they end up generating a huge number of instructions and so manually verifying it is not possible. I can generate a .o from them and run them for many test vectors, but then I don't know how to create test vectors for 256, 512 and 1024 bit vectors on i386. Is there anything that can help with this?
2. Can you look at `test/CodeGen/X86/libcall-sret.ll`? Is this test relevant anymore as `__multi3` will no longer be generated? Should it be removed or modified (if latter then how?).


https://reviews.llvm.org/D38668