[PATCH] D38864: [Sanitizers] By default build libFuzzer with frame pointers.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis added inline comments.


================
Comment at: lib/fuzzer/CMakeLists.txt:35
 
+if (NOT COMPILER_RT_LIBFUZZER_OMIT_FRAME_POINTER)
+  append_list_if(COMPILER_RT_HAS_OMIT_FRAME_POINTER_FLAG -fno-omit-frame-pointer LIBFUZZER_CFLAGS)
----------------
alekseyshl wrote:
> eugenis wrote:
> > COMPILER_RT_LIBFUZZER_OMIT_FRAME_POINTER - why is it needed? We don't have a similar escape hatch for every other compiler option, why start now?
> > 
> If your fuzz target is going to be built with no sanitizers, why would you need frame pointers? Or you think it's excessive and frame pointers are not a big deal to always have them?
No one really does that, I hope.
Also, libfuzzer is now part of the toolchain, and people building fuzz targets don't rebuild it.


https://reviews.llvm.org/D38864