[compiler-rt] r315620 - [cmake] [asan] Remove unnecessary gtest dep from dynamic tests

Michal Gorny via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 12 14:07:43 PDT 2017


Author: mgorny
Date: Thu Oct 12 14:07:43 2017
New Revision: 315620

URL: http://llvm.org/viewvc/llvm-project?rev=315620&view=rev
Log:
[cmake] [asan] Remove unnecessary gtest dep from dynamic tests

Remove the redundant dependency on 'gtest' target from the dynamic tests
in non-MSVC environment. The tests reuse compiled objects
from ASAN_INST_TEST_OBJECTS, and therefore they have been built against
gtest already.

This both fixes the spurious dependency on 'gtest' target that breaks
stand-alone builds, and brings the dynamic tests more in line with
regular tests which do not pass this dependency
to add_compiler_rt_test() through generate_compiler_rt_tests().

Differential Revision: https://reviews.llvm.org/D38840

Modified:
    compiler-rt/trunk/lib/asan/tests/CMakeLists.txt

Modified: compiler-rt/trunk/lib/asan/tests/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/tests/CMakeLists.txt?rev=315620&r1=315619&r2=315620&view=diff
==============================================================================
--- compiler-rt/trunk/lib/asan/tests/CMakeLists.txt (original)
+++ compiler-rt/trunk/lib/asan/tests/CMakeLists.txt Thu Oct 12 14:07:43 2017
@@ -205,7 +205,7 @@ function(add_asan_tests arch test_runtim
       add_compiler_rt_test(AsanDynamicUnitTests "${dynamic_test_name}" "${arch}"
         SUBDIR "dynamic"
         OBJECTS ${ASAN_INST_TEST_OBJECTS}
-        DEPS gtest asan ${ASAN_INST_TEST_OBJECTS}
+        DEPS asan ${ASAN_INST_TEST_OBJECTS}
         LINK_FLAGS ${ASAN_DYNAMIC_UNITTEST_INSTRUMENTED_LINK_FLAGS}
         )
     endif()




More information about the llvm-commits mailing list