[compiler-rt] r315605 - [cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS

Michal Gorny via llvm-commits llvm-commits at lists.llvm.org
Thu Oct 12 11:51:41 PDT 2017


Author: mgorny
Date: Thu Oct 12 11:51:41 2017
New Revision: 315605

URL: http://llvm.org/viewvc/llvm-project?rev=315605&view=rev
Log:
[cmake] [interception] Remove duplicate gtest from test COMPILE_DEPS

Fix the gtest dependency to be included in DEPS only, rather than
in COMPILE_DEPS + DEPS. The former variable is apparently used to
provide unconditional dependencies, while the latter are only used
for non-standalone builds. Since they are concatenated, specifying gtest
in both is redundant. Furthermore, including it in COMPILE_DEPS causes
build failure for standalone builds where 'gtest' target is not present.

Differential Revision: https://reviews.llvm.org/D38839

Modified:
    compiler-rt/trunk/lib/interception/tests/CMakeLists.txt

Modified: compiler-rt/trunk/lib/interception/tests/CMakeLists.txt
URL: http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/interception/tests/CMakeLists.txt?rev=315605&r1=315604&r2=315605&view=diff
==============================================================================
--- compiler-rt/trunk/lib/interception/tests/CMakeLists.txt (original)
+++ compiler-rt/trunk/lib/interception/tests/CMakeLists.txt Thu Oct 12 11:51:41 2017
@@ -89,7 +89,7 @@ macro(add_interception_tests_for_arch ar
     InterceptionUnitTests "Interception-${arch}-Test" ${arch}
     RUNTIME ${INTERCEPTION_COMMON_LIB}
     SOURCES ${INTERCEPTION_UNITTESTS} ${COMPILER_RT_GTEST_SOURCE}
-    COMPILE_DEPS gtest ${INTERCEPTION_TEST_HEADERS}
+    COMPILE_DEPS ${INTERCEPTION_TEST_HEADERS}
     DEPS gtest
     CFLAGS ${INTERCEPTION_TEST_CFLAGS_COMMON}
     LINK_FLAGS ${INTERCEPTION_TEST_LINK_FLAGS_COMMON})




More information about the llvm-commits mailing list