[PATCH] D37983: Add instruction subset for the ARC backend

[Pete Couperus via Phabricator via llvm-commits]

petecoup added a comment.

Hello Tatyana,

Thanks again for the work here.
I applied this patch, and am getting build errors (DecodeFromCyclicRange, ReadField used before declared, others).
Assuming these declarations get moved to the right places, my only remaining question is how others feel about the ReadField/ReadFields variadic templates.



================
Comment at: lib/Target/ARC/Disassembler/ARCDisassembler.cpp:265
+template <uint8_t _first, uint8_t _last, uint8_t... _ranges>
+static uint64_t ReadFields(uint64_t Insn) {
+  return ReadField<_first, _last>(Insn) |
----------------
This makes the users more compact, but it seems less readable.


Repository:
  rL LLVM

https://reviews.llvm.org/D37983