[PATCH] D38588: Clear LastMappingSymbols and LastEMS(Info) when resetting the ARM(AArch64)ELFStreamer

Yichao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 11 20:10:16 PDT 2017


yuyichao updated this revision to Diff 118735.
yuyichao added a comment.
Herald added a subscriber: mgorny.

I put together a really simple test based on the only other occurance of `streamer` in the tests (from DWARF tests). It reliably crashes without the patch and doesn't with the patch. This is about as much as what I can possibly come up with. A similar test can be added for AArch64 but won't be testing anything. I have no idea what result I should test.

Any other comments?


https://reviews.llvm.org/D38588

Files:
  lib/Target/AArch64/MCTargetDesc/AArch64ELFStreamer.cpp
  lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
  unittests/Target/ARM/CMakeLists.txt
  unittests/Target/ARM/ELFStreamer.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D38588.118735.patch
Type: text/x-patch
Size: 7697 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171012/33eb806f/attachment.bin>


More information about the llvm-commits mailing list