[PATCH] D38776: [codeview] Implement FPO data assembler directives

Reid Kleckner via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 11 11:05:55 PDT 2017


rnk marked an inline comment as done.
rnk added inline comments.


================
Comment at: llvm/lib/Target/X86/MCTargetDesc/X86WinCOFFTargetStreamer.cpp:264
+    switch (LLVMReg) {
+    // MSVC only seems to emit symbolic register names for EIP, EBP, and ESP,
+    // but the format seems to support more than that, so we emit them.
----------------
majnemer wrote:
> Comment needs to be updated now that you added more symbolic names.
I did update it, it now documents that we differ from MSVC here.


https://reviews.llvm.org/D38776





More information about the llvm-commits mailing list