[PATCH] D37534: [X86] Unsigned saturation subtraction canonicalization [the backend part]

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 11 10:36:00 PDT 2017


spatel added inline comments.


================
Comment at: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp:35928-35930
+    if (DAG.isEqualTo(MaxLHS, Op1))
+      SubusLHS = MaxRHS;
+    else if (DAG.isEqualTo(MaxRHS, Op1))
----------------
Sorry I didn't have a chance to look at this closely before commit, but why are we using isEqualTo() here? This pattern only applies to integer types, so we could use simple equality checks instead?


Repository:
  rL LLVM

https://reviews.llvm.org/D37534





More information about the llvm-commits mailing list