[PATCH] D38771: [x86] avoid infinite loop from SoftenFloatOperand (PR34866)

Chih-Hung Hsieh via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 11 10:22:46 PDT 2017


chh added a comment.

This change LGTM.
I added more comments in https://bugs.llvm.org/show_bug.cgi?id=34866.

Note that fp128-cast.ll tests only cover the cases with +mmx.
If the original change in https://reviews.llvm.org/D31156 could affect fp128 and no-mmx cases,
it would be better to add test cases for clang -mno-mmx and/or -mno-sse.


https://reviews.llvm.org/D38771





More information about the llvm-commits mailing list