[PATCH] D38802: [Dominators] Remove the NCA check

[Daniel Berlin via llvm-commits]

We could also avoid the other checks, and just build dominators with the
simple iterative dataflow algorithm and see if it comes out the same.
The verification of tree properties is nice, though, as it guarantees
correctness, while doing some other algorithm would just guarantee we maybe
implemented it wrong twice :)


On Wed, Oct 11, 2017 at 8:24 AM, Brian Rzycki via Phabricator <
reviews at reviews.llvm.org> wrote:

> brzycki accepted this revision.
> brzycki added a comment.
> This revision is now accepted and ready to land.
>
> When working on JumpThreading I never saw a failure due to NCD
> verification so I think you're intuition about other checks makes sense.
>
>
> https://reviews.llvm.org/D38802
>
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20171011/fc25d2a3/attachment.html>