[PATCH] D38771: [x86] avoid infinite loop from SoftenFloatOperand (PR34866)

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Oct 11 06:10:07 PDT 2017


spatel added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.cpp:35229
+      (Y.getOpcode() == ISD::BITCAST &&
+       Y.getOperand(0).getValueType() == MVT::f128))
+    return SDValue();
----------------
RKSimon wrote:
> Does this work?
> ```
> if (peekThroughBitcasts(X).getValueType() == MVT::f128) ||
>      peekThroughBitcasts(Y).getValueType() == MVT::f128))
> ```
Yes - that's better, thanks...and reminds me to chase down the remaining blockers for removing the loop in there.


https://reviews.llvm.org/D38771





More information about the llvm-commits mailing list